Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 external source maps in css-dist #2710

Merged
merged 1 commit into from
Jul 23, 2018
Merged

🔧 external source maps in css-dist #2710

merged 1 commit into from
Jul 23, 2018

Conversation

giladgray
Copy link
Contributor

enable --map flag to postcss to externalize sourcemap.

Sass compilation already generates a .css.map file but without this flag, postcss would encode and inline the sourcemap, ballooning blueprint.css from 293K to 396K during a supposed production step!

@blueprint-bot
Copy link

external source maps in css-dist

Preview: documentation | landing | table

themadcreator
themadcreator approved these changes Jul 23, 2018
View reviewed changes
Copy link
Contributor

@themadcreator themadcreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is only +1/-1, but i'm sad github doesn't report the difference between bundle sizes

@giladgray giladgray merged commit f557bc6 into develop Jul 23, 2018
@giladgray giladgray deleted the gg/css-dist-map branch July 23, 2018 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themadcreator themadcreator themadcreator approved these changes

Assignees
No one assigned
Labels
Domain: tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladgray @blueprint-bot @themadcreator